search

coin-or / python-mip

Python-MIP: collection of Python tools for the modeling and solution of Mixed-Integer Linear programs
Eclipse Public License 2.0
518 stars 92 forks source link

WIP: Use relative imports #152

Closed lpsinger closed 3 years ago

h-g-s commented 3 years ago

Hi, one motivation for the use of ugly "mip.Var" in typing was the documentation (sphinx, sphinx-autodoc-typehints), they only generated correct, cross-referenced documentation for types using the more verbose typing definition. Could you generate the documentation in your machine and check if it now works ?

lpsinger commented 3 years ago

@h-g-s, I'm working on it. Please treat this as work in progress (hence WIP); I only pushed it so that I could see the CI checks.

The rationale for this PR is that it should eventually fix some errors due to circular imports that I noticed when requesting a specific solver (e.g. Model(solver=CBC)).

h-g-s commented 3 years ago

ok !

lpsinger commented 3 years ago

Closing in favor of #155.