Inefficiency in disabling constraints

coin-or / qpOASES

Open-source C++ implementation of the recently proposed online active set strategy

GNU Lesser General Public License v2.1

365 stars 127 forks source link

Inefficiency in disabling constraints #56

Closed svigerske closed 4 years ago

svigerske commented 4 years ago

Issue created by migration from Trac.

Original creator: jgillis

Original creation time: 2016-11-30 11:08:38

Assignee: ferreau

Version: 3.2.0

While benchmarking a sparse QP solve, I stumbled upon some remark about a none-optimal piece of code (QProblem::setA). It was in fact consuming over 80% of time spent in qpOASES for some application.

For what its worth, I compiled a patch for this. It needs review and testing still, though.

svigerske commented 4 years ago

Attachment efficiency.patch by jgillis created at 2016-11-30 11:08:47

svigerske commented 4 years ago

Comment by ferreau created at 2016-11-30 12:40:55

Changing status from new to assigned.

svigerske commented 4 years ago

Comment by ferreau created at 2016-11-30 12:41:53

Thanks, we are going to have a look at this.

svigerske commented 4 years ago

Comment by ferreau created at 2016-11-30 12:41:53

Changing assignee from ferreau to @apotschka.

svigerske commented 4 years ago

Comment by ferreau created at 2016-11-30 12:41:53

Changing status from assigned to new.

svigerske commented 4 years ago

Comment by @apotschka created at 2017-01-12 19:46:00

Thanks, Joris! Great patch. It's in the trunk now. I only changed tab formatting and fixed a typo in a comment. I also added your name to the AUTHORS file.

svigerske commented 4 years ago

Comment by @apotschka created at 2017-01-12 19:46:57

Resolution: fixed