search

coin-or / qpOASES

Open-source C++ implementation of the recently proposed online active set strategy
GNU Lesser General Public License v2.1
365 stars 127 forks source link

a few minor usability issues #59

Closed svigerske closed 4 years ago

svigerske commented 4 years ago

Issue created by migration from Trac.

Original creator: asherikov

Original creation time: 2017-01-06 12:33:23

Assignee: ferreau

Version: 3.2.0

Sorry, I am too lazy to create separate PR's for these.

1) __SUPPRESSANYOUTPUT__ should not disable MessageHandling::getErrorCodeMessage() function in src/MessageHandling.cpp I don't want qpOASES to output anything, but I still want to have descriptions of errors. Quick patch is attached.

2) Compile examples optionally, see attached patch for CMakeLists.txt

3) -finline-functions compiler flag seems to be unnecessary, since it is implied by '-O3' gcc flag, while clang does not support it at all (and complains about it) -- [http://stackoverflow.com/questions/26108606/no-support-to-finline-functions-in-clang-3-5]

svigerske commented 4 years ago

Attachment cmakelists.patch by asherikov created at 2017-01-06 12:33:46

svigerske commented 4 years ago

Attachment messagehandling.patch by asherikov created at 2017-01-06 12:34:01

svigerske commented 4 years ago

Comment by ferreau created at 2017-03-28 08:34:48

Changing status from new to assigned.

svigerske commented 4 years ago

Comment by ferreau created at 2017-03-28 14:26:58

Thanks a lot for these suggestions. I have applied your path to the CMakeLists.txt and removed the -finline-functions compiler flag. It is now in the development trunk and will become part of release 3.2.1.

Regarding the first suggestion, your reasoning is absolutely valid. However, the idea behind introducing the __SUPPRESSANYOUTPUT__ flag was to make sure nothing is printed on an embedded device. Sometimes certain variants of the printf command are not supported. That's why we prefer to leave it as it is.

svigerske commented 4 years ago

Comment by ferreau created at 2017-03-28 14:26:58

Resolution: fixed