coin-or / qpOASES

Open-source C++ implementation of the recently proposed online active set strategy
GNU Lesser General Public License v2.1
376 stars 127 forks source link

octave interface does not pass Matlab unit tests #6

Open svigerske opened 4 years ago

svigerske commented 4 years ago

Issue created by migration from Trac.

Original creator: ferreau

Original creation time: 2014-07-23 19:16:54

Assignee: ferreau

Version: 3.0.0

octave interface (testing/matlab/runAllTests) does NOT run without errors!

In particular, test instances with special Hessian matrix sometimes result in "infeasible QPs" that actually should be feasible. All other tests do pass normally.

(changed by ferreau at 2015-08-28 08:07:40)

svigerske commented 4 years ago

Comment by ferreau created at 2014-07-23 19:25:39

Changing status from new to assigned.

svigerske commented 4 years ago

Comment by ferreau created at 2014-07-29 11:22:32

Changing assignee from ferreau to buchner.

svigerske commented 4 years ago

Comment by ferreau created at 2014-07-29 11:22:32

Changing status from assigned to new.

svigerske commented 4 years ago

Comment by buchner created at 2014-07-29 12:08:16

I added the missing test QPs to testing/matlab/data/.

Now works fine again.

svigerske commented 4 years ago

Comment by buchner created at 2014-07-29 12:08:16

Resolution: fixed

svigerske commented 4 years ago

Comment by ferreau created at 2014-07-29 12:25:28

Initially, I did not add the data on purpose as I did not want to flood users with MBytes of testing data. But I think it is fine to have them in the trunk, but we need to make sure they do NOT become part of stable/releases. Moreover, the tests have been setup in a way that tests where data is missing are simply skipped.

I have reopened the ticket as my rather outdated octave installation (3.2.4) under Ubuntu failed for two reasons

1) it cannot handle ~ arguments (so we should avoid them also for Matlab), 2) some tests did not pass even though they pass in Matlab.

I will give more details soon.

svigerske commented 4 years ago

Comment by ferreau created at 2014-07-29 12:25:28

Resolution changed from fixed to

svigerske commented 4 years ago

Comment by ferreau created at 2014-07-29 12:25:28

Changing status from closed to reopened.

svigerske commented 4 years ago

Comment by ferreau created at 2014-07-29 19:34:20

By the way, I have deleted the testing data from trunk again as this will only cause troubles when creating releases. Instead, they are stored in a new directory /misc/testingdata/. There are now shell scripts fetch_matlab_data and fetch_cpp_data such that any user can conveniently export this data if desired.

svigerske commented 4 years ago

Comment by ferreau created at 2014-07-30 16:15:36

Changing assignee from buchner to ferreau.

svigerske commented 4 years ago

Comment by ferreau created at 2014-07-30 16:15:36

Changing status from reopened to new.

svigerske commented 4 years ago

Comment by ferreau created at 2015-01-10 12:40:43

I removed all ~ output arguments once more in all tests. Moreover, I adjusted some tolerances that were slightly violated when running my octave 3.2.4 installation. Finally, the file testing/matlab/runAllTests.m was adapted such that it adds the octave interface path when running octave. Now, basically all Matlab tests pass on my machine when running them in octave, so I am going to close this ticket.

svigerske commented 4 years ago

Comment by ferreau created at 2015-01-10 12:40:43

Resolution: fixed

svigerske commented 4 years ago

Comment by ferreau created at 2015-08-28 08:07:40

It seems this issue has not been fully fixed. While all other tests do pass normally, test instances with special Hessian matrix sometimes result in "infeasible QPs" that actually should be feasible. Thus I reopen this ticket.

svigerske commented 4 years ago

Comment by ferreau created at 2015-08-28 08:07:40

Resolution changed from fixed to

svigerske commented 4 years ago

Comment by ferreau created at 2015-08-28 08:07:40

Changing status from closed to reopened.

svigerske commented 4 years ago

Comment by ferreau created at 2015-08-28 08:07:40

Version changed from 3.0.0 to 3.1.1

svigerske commented 4 years ago

Comment by ferreau created at 2015-08-28 08:08:13

Changing type from test request to runtime bug.