search

coin-or / rbfopt

RBFOpt library for black-box optimization
Other
188 stars 33 forks source link

Support Python 3 / NumPy 1.12 #10

Closed tsmithe closed 7 years ago

tsmithe commented 7 years ago

Hello,

I have been playing with rbfopt using recent Python and NumPy versions, and have attached a patch with a couple of suggested changes that make the tests usable (though by default the tests do not seem to find the optima; I do not know if that is a different bug, or expected, or somehow the result of using Python 3...). I would like to implore you to support recent versions of the software in this ecosystem: Python 3 is a very nice upgrade over 2.7, and time isn't going backwards!

rbfopt-py3-patch.txt

All the best, and thanks for the great software.

gnannicini commented 7 years ago

Hi Toby, thanks for the patch. The development branch on github supports Python 3. There are also numerous performance improvements and I am in the phase of testing to choose the best default settings. I didn't push development to master yet because I tend to be cautious with that, but I will make a release candidate soon. Notice that this would be a major version update and it is (slightly) backward incompatible.

Giacomo

On Thu, Jun 8, 2017 at 1:07 PM, Toby Smithe notifications@github.com wrote:

Hello,

I have been playing with rbfopt using recent Python and NumPy versions, and have attached a patch with a couple of suggested changes that make the tests usable (though by default the tests do not seem to find the optima; I do not know if that is a different bug, or expected, or somehow the result of using Python 3...). I would like to implore you to support recent versions of the software in this ecosystem: Python 3 is a very nice upgrade over 2.7, and time isn't going backwards!

rbfopt-py3-patch.txt https://github.com/coin-or/rbfopt/files/1061753/rbfopt-py3-patch.txt

All the best, and thanks for the great software.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/coin-or/rbfopt/issues/10, or mute the thread https://github.com/notifications/unsubscribe-auth/AMPqkhLZm1U-bbpn_0_Wqb6aA_kYThjVks5sCCpQgaJpZM4N0XJB .

tsmithe commented 7 years ago

Hi Giacomo,

Many thanks for the quick response. I look forward to the new release and all those to follow! In the meantime, I will devote myself to understanding rbfopt's algorithms.

Cheers,

Toby

gnannicini commented 7 years ago

All tests were passed, I updated the master with version 3. Lots of updates. I will make a new packaged release soon.

tsmithe commented 7 years ago

Wonderful, thanks!

On 09/06/17 17:10, Giacomo Nannicini wrote:

All tests were passed, I updated the master with version 3. Lots of updates. I will make a new packaged release soon.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/coin-or/rbfopt/issues/10#issuecomment-307431861, or mute the thread https://github.com/notifications/unsubscribe-auth/ADp84VqF-5kViWSGXheLyojG-VnP8GVKks5sCW57gaJpZM4N0XJB.