search

coin3d / dime

DXF import
BSD 3-Clause "New" or "Revised" License
13 stars 14 forks source link

Invalid reference to coin? #1

Closed VolkerEnderlein closed 6 years ago

VolkerEnderlein commented 6 years ago

Original report by Bernd Waibel (Bitbucket: waebbl, GitHub: waebbl).

In the root CMakeLists.txt file at line 271, there's an if clause

#!cmake

if(COIN_BUILD_SHARED_LIBS)

see https://bitbucket.org/Coin3D/dime/src/47290a4eb762478b2e71ddf6f88f2fce21bfde45/CMakeLists.txt#lines-271

Shouldn't this read

#!cmake
if(DIME_BUILD_SHARED_LIBS)

?

VolkerEnderlein commented 6 years ago

Original comment by Volker Enderlein (Bitbucket: VolkerEnderlein, GitHub: VolkerEnderlein).

Good catch :) Sure, it should read DIME_BUILD_SHARED_LIBS! The issue will be fixed tonight.

Cheers Volker

VolkerEnderlein commented 6 years ago

Original comment by Volker Enderlein (Bitbucket: VolkerEnderlein, GitHub: VolkerEnderlein).

Has been fixed with pull request #5. Thank you for reporting.