search

coin3d / pivy

python bindings to coin3d
ISC License
53 stars 37 forks source link

Pivy fails to build with Python 3.12 #105

Closed hobbes1069 closed 7 months ago

hobbes1069 commented 1 year ago

Relevant error:

[ 83%] Linking CXX shared module _soqt.so
cd /builddir/build/BUILD/pivy-0.6.8/redhat-linux-build/interfaces && /usr/bin/cmake -E cmake_link_script CMakeFiles/soqt.dir/link.txt --verbose=1
/usr/bin/g++ -fPIC -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -m64   -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -Wl,-z,relro -Wl,--as-needed  -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -Wl,--build-id=sha1 -specs=/usr/lib/rpm/redhat/redhat-package-notes -shared  -o _soqt.so CMakeFiles/soqt.dir/__/pivy/gui/soqtPYTHON_wrap.cxx.o  /usr/lib64/libSoQt.so.1.6.0 /usr/lib64/libCoin.so.4.0.0 /usr/lib64/libQt5OpenGL.so.5.15.10 /usr/lib64/libQt5Widgets.so.5.15.10 /usr/lib64/libQt5Gui.so.5.15.10 /usr/lib64/libQt5Core.so.5.15.10 /usr/lib64/libOpenGL.so /usr/lib64/libGLX.so /usr/lib64/libGLU.so /usr/lib64/libX11.so /usr/lib64/libXext.so /usr/lib64/libXi.so 
/builddir/build/BUILD/pivy-0.6.8/redhat-linux-build/pivy/coinPYTHON_wrap.cxx: In function 'PyObject* _wrap_SoInput_setBuffer(PyObject*, PyObject*)':
/builddir/build/BUILD/pivy-0.6.8/redhat-linux-build/pivy/coinPYTHON_wrap.cxx:39749:14: error: 'PyUnicode_GET_SIZE' was not declared in this scope; did you mean 'PyDict_GET_SIZE'?
39749 |       arg3 = PyUnicode_GET_SIZE(swig_obj[1]);
      |              ^~~~~~~~~~~~~~~~~~
      |              PyDict_GET_SIZE

Full logs: https://kojipkgs.fedoraproject.org//work/tasks/1786/102981786/build.log

hobbes1069 commented 1 year ago

Changing PyUnicode_GET_SIZE to PyUnicode_GET_LENGTH fixed the build.

looooo commented 1 year ago

thanks, https://github.com/coin3d/pivy/commit/d3faf04b8770c60ca9b2186059ee82201e3620ad

looooo commented 7 months ago

can we close this? @hobbes1069

hobbes1069 commented 7 months ago

Confirmed.