coin3d / pivy

python bindings to coin3d
ISC License
53 stars 37 forks source link

0.6.5a1: windows failing #53

Closed looooo closed 5 years ago

looooo commented 5 years ago

https://ci.appveyor.com/project/conda-forge/pivy-feedstock/builds/24469708/job/7k7no2jbe3d5cw5t

C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\BIN\amd64\cl.exe /c /nologo /Ox /W3 /GL /DNDEBUG /MD -I%PREFIX%\include -I%PREFIX%\include "-IC:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\INCLUDE" "-IC:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\ATLMFC\INCLUDE" "-IC:\Program Files (x86)\Windows Kits\10\include\10.0.14393.0\ucrt" "-IC:\Program Files (x86)\Windows Kits\NETFXSDK\4.6.1\include\um" "-IC:\Program Files (x86)\Windows Kits\10\include\10.0.14393.0\shared" "-IC:\Program Files (x86)\Windows Kits\10\include\10.0.14393.0\um" "-IC:\Program Files (x86)\Windows Kits\10\include\10.0.14393.0\winrt" -I%PREFIX%\Library\include -I%PREFIX%\Library\include /EHsc /Tppivy\coin_wrap.cpp /Fobuild\temp.win-amd64-3.6\Release\pivy\coin_wrap.obj -Iinterfaces -IC:/bld/pivy_1557563866252/_h_env/Library/include -IC:/bld/pivy_1557563866252/_h_env/Library/include\Inventor\annex -Wno-unused -Wno-maybe-uninitialized
cl : Command line error D8021 : invalid numeric argument '/Wno-unused'
error: command 'C:\\Program Files (x86)\\Microsoft Visual Studio 14.0\\VC\\BIN\\amd64\\cl.exe' failed with exit status 2

reason (maybe): windows needs quotes for include directories!

wwmayer commented 5 years ago

I think instead of "-IC:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\INCLUDE" it should be -I"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\INCLUDE"

looooo commented 5 years ago

thanks, done here: https://github.com/FreeCAD/pivy/commit/fe8c590828913f75e5009d943967d3ebedc0caab