Fedora26 - Githubissues

coin3d / quarter

Coin GUI binding for Qt

BSD 3-Clause "New" or "Revised" License

36 stars 26 forks source link

Fedora26 #19

Closed VolkerEnderlein closed 4 years ago

VolkerEnderlein commented 4 years ago

Original pull request by Giampiero Gabbiani (Bitbucket: ggabbiani, GitHub: ggabbiani).

The installation path for the Quarter library was always set to CMAKE_INSTALL_PREFIX/lib that is not always correct for linux systems with x86_64 architecture. Now the path for the RUNTIME|LIBRARY|ARCHIVE Quarter library targets is left to the underlying CMAKEINSTALL{BIN,LIB,LIB}DIR variables as initialized from the inclusion of GNUInstallDirs cmake macro.
fixed configuration on QT5 using the corred qt macro
Fixed for compiling the plugin under qt5 new plugin interface
fixed installation path for the designer plugin target by retrieving the qt5 plugin install directory

VolkerEnderlein commented 4 years ago

Original comment by Bastiaan Veelo (Bitbucket: veelo, GitHub: veelo).

Looks good to me. However this can be merged into the default branch of Quarter. The CMake branch was only created for pull request #16 (which I pulled just now) because it is dependent on the CMake branch of Coin.

If you'd rather have it in default then please make a new PR, else I'll happily merge it into CMake.

VolkerEnderlein commented 4 years ago

Original comment by Bastiaan Veelo (Bitbucket: veelo, GitHub: veelo).

Some of this was already part of pull request #18 which is still in the queue. Sorry you had to repeat the work.

VolkerEnderlein commented 4 years ago

Original comment by Giampiero Gabbiani (Bitbucket: ggabbiani, GitHub: ggabbiani).

Hi Bastiaan, my fault, I had to look better in the already existing prs!

Honestly I just re-assembled some changes I did this summer and that completely forgot about!

I think this request can be deleted , and after the merge of the pr #8 if something remain I can do another one to be added to the default branch.

Best regards Giampiero

VolkerEnderlein commented 4 years ago

Original comment by Bastiaan Veelo (Bitbucket: veelo, GitHub: veelo).

Thanks. I just pulled request #8. Some of that was also part of pull request #13, but that one contains so many unrelated changes it is hard to review.