Fix cpack - Githubissues

coin3d / quarter

Coin GUI binding for Qt

BSD 3-Clause "New" or "Revised" License

36 stars 26 forks source link

Fix cpack #22

Closed VolkerEnderlein closed 4 years ago

VolkerEnderlein commented 4 years ago

Original pull request by Giampiero Gabbiani (Bitbucket: ggabbiani, GitHub: ggabbiani).

fixed project versions
fixed examples [re]location
assigned component development, runtime and examples to the targets
added generation of QuarterConfig.cmake and QuarterConfigVersion.cmake
new cpack implementation (cleaner and maybe the right pattern to reproduce in the rest of the collection)

Regards

Giampiero

VolkerEnderlein commented 4 years ago

Original comment by Bastiaan Veelo (Bitbucket: veelo, GitHub: veelo).

How well will /opt play on Windows?

VolkerEnderlein commented 4 years ago

Original comment by Giampiero Gabbiani (Bitbucket: ggabbiani, GitHub: ggabbiani).

You are right Bastiaan, I guess it doesn't . The problem is that I didn't find a suitable place where for 'examples' ... maybe it make sense not to install the examples at all...

Let me know I can cancel and redo the pr.

Regards

Giampiero

VolkerEnderlein commented 4 years ago

Original comment by Bastiaan Veelo (Bitbucket: veelo, GitHub: veelo).

Maybe put an ELSE here to define the QUARTER_INSTALL_EXAMPLEDIR for non-Windows? What happens if that variable is not defined?

On the other hand, I think you are right that examples need not be installed. They are for developers, and if devs can build them and find them somewhere that should be enough.

VolkerEnderlein commented 4 years ago

Original comment by Bastiaan Veelo (Bitbucket: veelo, GitHub: veelo).

I think there is no need to cancel, you can push additional commits to the PR branch. https://stackoverflow.com/questions/41682243/update-the-code-for-a-bitbucket-pull-request-mercurial

VolkerEnderlein commented 4 years ago

Original comment by Bastiaan Veelo (Bitbucket: veelo, GitHub: veelo).

Thanks again!