search

coin3d / simage

Image file loading
ISC License
7 stars 9 forks source link

simage doesn't compile because libgif #1

Closed VolkerEnderlein closed 6 years ago

VolkerEnderlein commented 6 years ago

Original report by Leopold Palomo-Avellaneda (Bitbucket: lepalom, GitHub: lepalom).

trying to build simage against libgif 5.1.4 I got this error:

/srv/drp/packages/coin/simage/src/simage_gif.c: In function ‘simage_gif_load’: /srv/drp/packages/coin/simage/src/simage_gif.c:134:13: error: too few arguments to function ‘DGifOpenFileName’ giffile = DGifOpenFileName(filename); ^~~~ In file included from /srv/drp/packages/coin/simage/src/simage_gif.c:32:0: /usr/include/gif_lib.h:179:14: note: declared here GifFileType DGifOpenFileName(const char GifFileName, int Error); ^~~~ /srv/drp/packages/coin/simage/src/simage_gif.c:265:3: error: too few arguments to function ‘DGifCloseFile’ DGifCloseFile(giffile); ^~~~~ In file included from /srv/drp/packages/coin/simage/src/simage_gif.c:32:0: /usr/include/gif_lib.h:183:9: note: declared here int DGifCloseFile(GifFileType GifFile, int *ErrorCode); ^~~~~

surfing on the net I have found:

https://github.com/Automattic/node-canvas/issues/440

so, it seems easy to solve.

VolkerEnderlein commented 6 years ago

Original comment by barcode (Bitbucket: raphael_grimm, ).

Added a PR for a fix (https://bitbucket.org/Coin3D/simage/pull-requests/7/fix-new-giflib/diff)

VolkerEnderlein commented 6 years ago

Original comment by Volker Enderlein (Bitbucket: VolkerEnderlein, GitHub: VolkerEnderlein).

I am closing this issue as it has been resolved with pull request #10. Feel free to reopen the issue if the problem still persists.