search

coin3d / simage

Image file loading
ISC License
7 stars 9 forks source link

CMake error on macOS due to missing Welcome.rtf #35

Closed rickertm closed 4 years ago

rickertm commented 4 years ago

In release 1.8.0 and on the current master with enabled SIMAGE_USE_CPACK option, CMake cannot complete the configuration due to a missing Welcome.rtf. See cpack.d line 122 for the relevant code.

CMake Error: File /Users/test/workspace/simage/packaging/macosx/Welcome.rtf does not exist.
CMake Error at cpack.d/CMakeLists.txt:122 (configure_file):
  configure_file Problem configuring file

-- Configuring incomplete, errors occurred!
veelo commented 4 years ago

@VolkerEnderlein the line in question is yours, from 12 months ago (or is that due to the hg=>git conversion?). Or maybe something changed on the cpack side of things, @ggabbiani? Anyway, I'm out of my league here...

ggabbiani commented 4 years ago

cpack.d is missing git support , I have already fixed locally some time ago but I had no time to push the changes. I guess that that the log should anyway report a warn about 'Mercurial found'. I can take care of both.

Giampiero

ggabbiani commented 4 years ago

Hi Markus,

just updated cpack.d with the proper cmake code for correct build with the new git repo.

I also added to simage the missing Welcome.rtf file.

Unfortunately I don't have a Mac for checking these changes, and after a look to the DMGSetup.scpt.in I suspect that at least another tiff file is missing in simage/packaging/macosx.

@rickertm could you check now?

@VolkerEnderlein please Volker in case anything else is missing for Mac could you check end eventually fix?

In the meanwhile I will propagate the changes in the cpack.d to all the other client projects.

Regards Giampiero

rickertm commented 4 years ago

Thank you for adding the file. I can confirm that the CMake configure step now works on macOS with enabled SIMAGE_USE_CPACK option.

It would be nice if you can tag a new version with these changes.

VolkerEnderlein commented 4 years ago

@veelo Unfortunately I am not able to react properly, because I am on holidays. Will check on saturday when I'm back. Cheers, Volker

Am 11.02.2020 00:07 schrieb Bastiaan Veelo notifications@github.com:

@VolkerEnderleinhttps://github.com/VolkerEnderlein the line in question is yours, from 12 months ago (or is that due to the hg=>git conversion?). Or maybe something changed on the cpack side of things, @ggabbianihttps://github.com/ggabbiani? Anyway, I'm out of my league here...