search

coin3d / simage

Image file loading
ISC License
7 stars 9 forks source link

Added compile tests for Video For Windows and GDI Plus instead of FindPackage cmake methods #56

Closed ChrisSchulte closed 2 years ago

ChrisSchulte commented 2 years ago

As discussed in issue #55 here is a proposal of replacing the find package methods by two try compile checks for Video for Windows and for GDI Plus on Windows platforms. Tested agains Windows 10 with and without SDK 10.

VolkerEnderlein commented 2 years ago

Hi Chris, I checked the PR, simage can be compiled and built but I had a more minimal approach in mind, see attached CMakeLists.txt. Maybe you can check this out and adapt this PR if you think it fits better. Otherwise I am happy to merge your PR as is. Cheers Volker CMakeLists.txt

ChrisSchulte commented 2 years ago

Hi Volker, I'm sorry but I can't see any differences between my CMakeLists.txt and the one you attached. Are you sure you attached the right file ? Cheers, Chris

VolkerEnderlein commented 2 years ago

You are right I mixed up the attachment. Please have a look at the new file here. CMakeLists.txt

ChrisSchulte commented 2 years ago

Hi Volker, I've checked your solution and it does work for me. It is clearly an easier solution but in my opinion it is better to externalize the tests as it makes the CmakeLists file easier to read and to evolve. Both solution work so it is up to you to choose which one you want to implement, as you are the maintainer. Cheers Chris

VolkerEnderlein commented 2 years ago

I finally decided to use the simplest solution as I do not expect much growing in simage's build system. Anyway, thanks a lot for your thorough issue report and the valuable contribution.