coin3d / soqt

Old Coin GUI binding for Qt, replaced by Quarter
BSD 3-Clause "New" or "Revised" License
22 stars 17 forks source link

Releases for submodules soanydata, cpack.d #54

Closed looooo closed 4 years ago

looooo commented 4 years ago

To build soqt, it's necessary to have sources of sogui, soanydata, cpack.d available. While sogui is available as version 1.4.0 I am missing releases for soanydata and cpack.d. Would it be possible to create these releases?

looooo commented 4 years ago

Also I think the cpack-submodule shouldn't be mandatory and should be disabled by default:

lepalom commented 4 years ago

I think that it could be useful if you make a release of the corresponding submodules of soqt in the way that a SoQt release with its modules. In my case I'm be able to execute uscan to obtain the necessary sources to build the debian package.

hobbes1069 commented 4 years ago

Just found the github move. GOOD!

Ok, so I worked around the git submodules in a very ugly way for Fedora but it works (documented at the bottom). However, I'm not sure how easy this is to do but what should really happen is the official release archives should already have the submodules included. Period. That's the point of providing release archives. It should be complete.

To make updates manageable in the spec file I put this in the header:

%global cpack_hash 118ac5a21bcf57f0f90e2b0e681c9dcbf07074c2
%global cpack_short %(c=%{cpack_hash}; echo ${c:0:10})
%global cpack_date 20200419
%global soanydata_hash 3ff6e9203fbb0cc08a2bdf209212b7ef4d78a1f2
%global soanydata_short %(c=%{soanydata_hash}; echo ${c:0:10})
%global soanydata_date 20200419
%global sogui_hash 4b0019d1ecc2b9ad3e77333b9f243b57a15ebc4e
%global sogui_short %(c=%{soanydata_hash}; echo ${c:0:10})
%global sogui_date 20200419

The sources later in the spec file:

Source1:        https://github.com/coin3d/cpack.d/archive/%{cpack_hash}/coin3d-cpack-%{cpack_date}git%{cpack_short}.tar.gz
Source2:        https://github.com/coin3d/soanydata/archive/%{soanydata_hash}/coin3d-soanydata-%{soanydata_date}git%{soanydata_short}.tar.gz
Source3:        https://github.com/coin3d/sogui/archive/%{sogui_hash}/coin3d-sogui-%{sogui_date}git%{sogui_short}.tar.gz

And then unpack them in %prep:

mkdir cpack.d data src/Inventor/Qt/common
tar --strip-components=1 -C cpack.d -xf %{SOURCE1}
tar --strip-components=1 -C data -xf %{SOURCE2}
tar --strip-components=1 -C src/Inventor/Qt/common -xf %{SOURCE3}
VolkerEnderlein commented 4 years ago

The releases of coin 4.0.0, soqt 1.6.0, sowin 1.6.0, soxt 1.4.0, simage 1.8.0, superglu 1.3.0, simvoleon 2.1.0, dime 0.9.1, profit 0.9.1, and smallchange 1.0.0 have been populated on the Coin3D GitHub repository with fully functional source tarballs and zip files that include sogui, soanydata, and cpack.d. SHA256 and MD5 files are also in place. Additionally releases for sogui (tags soxt-1_4_0, soqt-1_6_0, soqt-1_6_0) cpack.d (tag cpack.d-1_0_0) and soanydata (tag soanydata-1_1_0) have been done. Hope that helps for the package maintainers.

hobbes1069 commented 4 years ago

Ok, github still does the automated archives at the bottom, so I just need to use the uploaded archive, correct?

VolkerEnderlein commented 4 years ago

Exactly. I cannot make those links disappear :(

hobbes1069 commented 4 years ago

No worries, I know better now. Doesn't look like I can close the issue though.

VolkerEnderlein commented 4 years ago

@looooo Do you think we can close this issue?

looooo commented 4 years ago

Yes, if pulling all the submodules is not be necessary anymore. I haven't tried yet. https://github.com/conda-forge/soqt-feedstock/blob/master/recipe/meta.yaml#L16L25

VolkerEnderlein commented 4 years ago

The archives are created automatically by GitHub and therefore do not contain the submodules up to now. I provided separate source tarballs in the releases including the submodules that can be downloaded from: https://github.com/coin3d/superglu/releases/download/superglu-1.3.0/superglu-1.3.0-src.tar.gz https://github.com/coin3d/coin/releases/download/Coin-4.0.0/coin-4.0.0-src.tar.gz https://github.com/coin3d/soqt/releases/download/SoQt-1.6.0/soqt-1.6.0-src.tar.gz https://github.com/coin3d/simage/releases/download/simage-1.8.0/simage-1.8.0-src.tar.gz There are zip files and SHA256 and MD5 checksum files as well for those packages.

looooo commented 4 years ago

perfect, thanks, I will try to remember.