search

coinables / segwitaddress

segwit paper wallet address generator P2WPKH
MIT License
104 stars 55 forks source link

offline, tries to call bitpay.com feelevels #19

Open petjal opened 3 years ago

petjal commented 3 years ago

Love this project, thanks, very simple for me to help family. friends, and confidants.
My derivative work in progress: https://github.com/petjal/bitcoin-beginner-howto

I think, so far, it is safe enough.

Testing https://github.com/coinables/segwitaddress/releases/tag/v0.4.2 using private browser dev tools, offline, I see two (failed) calls to bitpay.com https://github.com/coinables/segwitaddress/search?q=feelevels

No biggie, I think, just distracting, and hopefully unnecessary and easy to remove.

Thanks again!

coinables commented 3 years ago

Fee estimates are really helpful during times of high network traffic and fees. Bitpay always over estimates fees so I take their economy fee and cut in in half for the default. If you are offline and attempt to use the sweep feature it will not be able to find UTXOs so the sweep cannot be used offline which is the only part that uses the fee estimate. If you're looking for a completely offline way to sign transactions look at Cold Signer (https://github.com/coinables/coinables.github.io/tree/master/coldsigner). I don't see a need to remove the fee estimation at this time, but absolutely open to other opinions on the matter so I'll leave the issue open.