search

coinbase / build-onchain-apps

Accelerate your onchain creativity with the Build Onchain Apps Template. ⛵️
https://buildonchainapps.xyz
MIT License
704 stars 115 forks source link

Bug Bash Feb 2024 #366

Open Zizzamia opened 6 months ago

Zizzamia commented 6 months ago

Describe the bug and the steps to reproduce it

Time to catch some bugs and ideas for BOAT

everart image (6)

What's the expected behavior?

No response

What version of the libraries are you using?

No response

Sneh1999 commented 6 months ago

Number of wallets we support right now are low image

Sneh1999 commented 6 months ago

Everyone has the same avatar image, should be randomized image

Sneh1999 commented 6 months ago

Twitter handle should open twitter: image

Sneh1999 commented 6 months ago

This div currently doesnt portray any relevant information: image

arsood commented 6 months ago

Buy Me a Coffee flow doesn't work anymore again. When I attempt to purchase, I get to the pending state and it is stuck there even after verifying on my wallet.

Screenshot 2024-02-15 at 11 38 34 AM

Also, the memo is not added and doesn't show on refresh.

Sneh1999 commented 6 months ago

Links dont work here image

arsood commented 6 months ago

Mint NFT flow doesn't seem to work. Just stuck on minting in progress even after confirming in wallet.

Screenshot 2024-02-15 at 11 41 27 AM
Sneh1999 commented 6 months ago

I dont think testnet NFT's show up in the wallet, so this message might not be right image

arsood commented 6 months ago

When there are a lot of memos in the Buy Me a Coffee page, the guide is pushed down way too far. Should we either 1. move the guide somewhere else or 2. paginate the memos?

Sneh1999 commented 6 months ago

List here is incomplete and doesnt match the README image

robpolak commented 6 months ago

Everyone has the same avatar image, should be randomized image

Why not ENS profile image??

Sneh1999 commented 6 months ago

Buy Me a Coffee flow doesn't work anymore again. When I attempt to purchase, I get to the pending state and it is stuck there even after verifying on my wallet.

Screenshot 2024-02-15 at 11 38 34 AM

Also, the memo is not added and doesn't show on refresh.

It seems to be working for me, not sure

robpolak commented 6 months ago

Error is not obvious and text entry boxes are disabled: image

I think we should:

  1. Give the error some color to stand out
  2. Give text boxes a more pronounced style when disabled.
robpolak commented 6 months ago

Text should wrap : image

eragon512 commented 6 months ago

Rendering too many items without a limit Screenshot 2024-02-16 at 01-17-02 Build Onchain Apps Toolkit

eragon512 commented 6 months ago

[Phone landscape view] Logout button gets cut off and is not inaccessible even while scrolling in the page

Screenshot 2024-02-16 at 1 24 14 AM
danimesq commented 1 month ago

@Sneh1999 "Number of wallets we support right now are low" What you modified to replace SmartWallet by the WalletConnect modal?

"This div currently doesnt portray any relevant information:" In the current implementation, I didn't see this div. Maybe because my environment is localhost rather than production?

@arsood "When there are a lot of memos in the Buy Me a Coffee page, the guide is pushed down way too far. Should we either 1. move the guide somewhere else or 2. paginate the memos?" Going to be fixed via https://github.com/coinbase/build-onchain-apps/pull/516.

@eragon512 "Rendering too many items without a limit" Same as the above addressing.

@robpolak "Text should wrap :" This issue has been fixed already.

I will try to submit some PRs to fix the following issues:

danimesq commented 1 month ago

I'll have to halt my PRs, because: I've heard somewhere that BOAT is going to be ditched to focus on onchain-kit. Basing that rumour, the repo has no commits for more than a month.

ping @arsood @Zizzamia to know news about this repo, so I may feel comfortable to send PRs to a template that hasn't been abandonned.

Zizzamia commented 1 month ago

Yup, OnchainKit is the priority at the moment. And there is an active plan to build a small collection of Templates based on OnchainKit.

Those templates are probably going to live inside the OnchainKit repo.

Thank you for caring, and reaching out. I will say, if you want to contribute, https://github.com/coinbase/onchainkit is the place.

As soon as we have Templates in the OnchainKit repo, I am probably going to deprecate this one.

danimesq commented 1 month ago

@Zizzamia "Those templates are probably going to live inside the OnchainKit repo." Couldn't BOAT be one of these templates? An idea is to use "git pull --allow-unrelated-histories" to keep the current history of BOAT's repo. Or making every template their own repos instead of a monorepo?

Just think it's sad for BOAT's code to be wasted, and its commits history as well.

Zizzamia commented 1 month ago

You right! Let keep this repo, and I will do a few adjustments this week:

@danimesq what do you think about that?

danimesq commented 1 month ago

@Zizzamia I think this makes sense! Let's see now the opinion of Base/OnchainKit team 🙏

So, a separate CLI for choosing a template repo the user will get? Or, why not keeping the templates+CLI a monorepo as a boilerplate to kickstart OnchainKit?

Zizzamia commented 4 weeks ago

I started refactoring BOAT into something more simple.

Also as you noticed, we just launch https://github.com/coinbase/onchain-app-template, to help simplify how we are approaching templates.