coinbase / cdp-agentkit

Other
80 stars 66 forks source link

Add ability to pass in custom metadata for wow token creation #46

Closed erikreppel closed 1 week ago

erikreppel commented 1 week ago

What changed? Why?

Currently all tokens created on wow through this tool have the same token metadata, allow passing custom metadata so people can override things like token image

Qualified Impact

works case it'd break the tool, seems unlikely

cb-heimdall commented 1 week ago

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1
erikreppel commented 1 week ago

@John-peterson-coinbase I think I got all your PR feedback!

John-peterson-coinbase commented 1 week ago

@erikreppel - LGTM!

We require the commits to be signed for them to be merged to master. https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification

Please follow the linked instructions to set up GPG signing and then squash the commits into 1 signed commit.

I can help with merging once the commits are signed!

erikreppel commented 1 week ago

@John-peterson-coinbase signed