Closed erikreppel closed 1 week ago
Requirement | Status | More Info | ||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Reviews |
✅
1/1
|
Denominator calculation
|
@John-peterson-coinbase I think I got all your PR feedback!
@erikreppel - LGTM!
We require the commits to be signed for them to be merged to master. https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification
Please follow the linked instructions to set up GPG signing and then squash the commits into 1 signed commit.
I can help with merging once the commits are signed!
@John-peterson-coinbase signed
What changed? Why?
Currently all tokens created on wow through this tool have the same token metadata, allow passing custom metadata so people can override things like token image
Qualified Impact
works case it'd break the tool, seems unlikely