Added return type to jwt_generator.build_jwt()

coinbase / coinbase-advanced-py

The Advanced API Python SDK is a Python package that makes it easy to interact with the Coinbase Advanced API. The SDK handles authentication, HTTP connections, and provides helpful methods for interacting with the API.

https://docs.cdp.coinbase.com/advanced-trade/docs/welcome/

Apache License 2.0

101 stars 27 forks source link

Added return type to jwt_generator.build_jwt() #27

Closed StarringLara closed 6 months ago

StarringLara commented 7 months ago

Types should be defined wherever possible. This helps users of the SDK know what is required and expected. User's IDEs/editors will often show them what types are returned or expected. The more types there are, the more mypy can validate them in this project and thus validate more of the code in this project. This will also help users of mypy in their own projects that use this SDK to know what types are required.

urischwartz-cb commented 6 months ago

Closing this PR since we pushed v1.1.3 with the suggested annotations.