search

coinbase / coinbase-java

Coinbase API v1 library for Java
Apache License 2.0
149 stars 98 forks source link

Java 6 support #3

Closed chashi closed 10 years ago

chashi commented 10 years ago

The artifacts uploaded to Maven central are compiled with Java 7. Would it be possible to either compile future version using Java 6, or, upload both the default Java 7 version and also a Java 6 version with a classifier?

Reason I ask is because 6 is still widely used. I would conjecture it especially has a lot of popularity in the enterprise space as enterprises are generally slower to react to versioning updates.

Where I work we are in this situation. Our application servers use 6. For our purposes the solution is easy enough, but tedious. Recreate the artifact with 6 and upload to our corporate Nexus repository for distribution internally. The 1.3.0 source compiled just fine using Java 6, all tests passed, and the single feature I'm using from this library (createButton) is working as expected.

aianus commented 10 years ago

Since we're not really using any 1.7 features I set compiler source and target to 1.6 in the pom.

Try out 1.3.2-SNAPSHOT at https://oss.sonatype.org/content/repositories/snapshots/ to confirm it's working for you now.

chashi commented 10 years ago

Yep this is perfect.