search

coinbase / coinbase-pro-node

DEPRECATED — The official Node.js library for Coinbase Pro
Apache License 2.0
844 stars 316 forks source link

Fix cancelAllOrders compile error. #303

Closed blair closed 6 years ago

blair commented 6 years ago

Make the args argument required, but make its product_id property optional, so it's still easy to not set it.

index.d.ts(225,56): error TS1016: A required parameter cannot follow an optional parameter.

fuksi commented 6 years ago

@fb55 It seems that this change is not published yet, since the latest version still have the error https://github.com/coinbase/gdax-node/blob/v0.7.0/index.d.ts#L225