search

coinbase / coinbase-pro-trading-toolkit

DEPRECATED — The Coinbase Pro trading toolkit
Apache License 2.0
866 stars 239 forks source link

Calculation for 12h and 1d is incorrect in IntervalInMS #259

Closed djflux closed 4 years ago

djflux commented 5 years ago

The calculation for the 12h and 1d intervals in IntervalInMS in src/exchanges/PublicExchangeAPI.ts uses incorrect values.

Here is the code:

IntervalInMS['12h'] = 12 * IntervalInMS['12h'];
IntervalInMS['1d'] = 24 * IntervalInMS['24h'];

I believe the correct code should read:

IntervalInMS['12h'] = 12 * IntervalInMS['1h'];
IntervalInMS['1d'] = 24 * IntervalInMS['1h'];

Going to submit a pull request with a fix.

Thanks again for the great toolkit.

drewrothstein commented 4 years ago

Hi, we are closing out PRs + Issues as this project is being archived.