coinbase / coinbase-python

DEPRECATED — Coinbase Python API
Apache License 2.0
528 stars 217 forks source link

get_historic_prices accepts a currency pair #38

Closed spiliopoulos closed 6 years ago

spiliopoulos commented 7 years ago

get_historic_prices was not accepting a currency_pair parameter and as a result would only return BTC-USD prices. I modified it, following the template used in the other functions querying the prices endpoint.

rugheid commented 7 years ago

When can this PR be merged? I'm currently using the version of @spiliopoulos because I need historic prices for Ethereum.

PierreRochard commented 7 years ago

@rugheid not sure that you'll ever get a response here. Coinbase is pivoting towards "tokens" and is unlikely to improve their existing libraries, site reliability, or customer support in any way. They mistakenly see the brokerage and exchange products as legacy tech debt that they are burdened with and won't pay off. 😞 They might say that's not true, but watch what they do, not what they say.

https://twitter.com/ismailjh/status/867141537829982208

rugheid commented 7 years ago

@PierreRochard Thanks for the warming, I already noticed it's all getting out of date. It's a shame it's so hard to find nice API's to train automatic traders.

sds commented 6 years ago

Rebased and merged as b07e6407, with a test added in d210deda. Would appreciate folks taking it for a spin before we ship a new release. Thanks!