coinbase / coinbase-sdk-nodejs

Other

78 stars 29 forks source link

Support webhook signature header #192

Closed chaoyaji-cb closed 2 months ago

chaoyaji-cb commented 2 months ago

What changed? Why?

Added the signature header attribute when create webhook
Drop unnecessary fields when update the webhook

> const w4 = await Webhook.create('base-mainnet', 'https://bug_bash.net', 'erc20_transfer', [{ contract_address: '0x24d6C74D811cfDe65995Ed26FD08Af445f8aaB06' }], 'node_js_testing')
undefined
> w4.toString()
`Webhook { id: '66cf98862b3574304368e6b9', network_id: 'base-mainnet', event_type: 'erc20_transfer', event_filter: [{"contract_address":"0x24d6C74D811cfDe65995Ed26FD08Af445f8aaB06"}], notification_uri: 'https://bug_bash.net', signature_header: 'node_js_testing' }`

Qualified Impact

cb-heimdall commented 2 months ago

🟡 Heimdall Review Status

Requirement Status More Info

Reviews

🟡 0/1

Denominator calculation

Show calculation

1 if user is bot 0

1 if user is external 0

From .codeflow.yml 1

Additional review requirements

Show calculation

Max

From CODEOWNERS 0

Global minimum 0

Max 1

1 if commit is unverified 0

Sum 1