search

coinbase / coinbase-sdk-ruby

Other
37 stars 11 forks source link

Enable all new rubocop linters and configure rubocop-rspec linting #132

Closed alex-stone closed 2 months ago

alex-stone commented 2 months ago

What changed? Why?

This updates our linting rules to add new cops as well as rubocop-rspec. This also addresses most of the violations.

Note: Renaming the E2E tests is difficult because we call rspec spec/e2e/end_to_end.rb across multiple versions, so we'd need to add handling to support that or duplicate the file for a few versions, neither of which feels better than just disabling the linting rule.

Qualified Impact

This mostly impacts minor linting related things, but touches some flows:

cb-heimdall commented 2 months ago

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1