coinbase / coinbase-sdk-ruby

Other
37 stars 11 forks source link

Refactor Wallet class to use delegators #136

Closed alex-stone closed 2 months ago

alex-stone commented 2 months ago

What changed? Why?

This refactors the Wallet class to use explicit delegators for forwarding to the default address so we do not need to redefine arguments in two places and potentially have them become out of sync.

Qualified Impact

cb-heimdall commented 2 months ago

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1