Clean up PopupCommunicator

coinbase / coinbase-wallet-sdk

An open protocol that lets users connect their mobile wallets to your DApp

MIT License

1.45k stars 561 forks source link

Closed bangtoven closed 5 months ago

bangtoven commented 5 months ago

consolidate CrossDomainCommunicator and PopUpCommunicator
introduce onMessage to listen for individual event, deprecating global event handling using requestMap
let postMessage take care of popup's availability, instead of requiring .connect() to be called beforehand
SignHandler to extend Communicator instead of having instance of it

bangtoven commented 5 months ago

feel free to push commits directly to this branch as you see fit

fan-zhang-sv commented 5 months ago

omg are you serious! this PR is soooooo gooooooooooood