search

coinbase / coinbase-wallet-sdk

An open protocol that lets users connect their mobile wallets to your DApp
https://coinbase.github.io/coinbase-wallet-sdk/
MIT License
1.4k stars 521 forks source link

Feature Request: SmartWallet - Allow owners to be initialized implicitly at time of setup #1275

Open Silur opened 1 month ago

Silur commented 1 month ago

Is your feature request related to a problem? Please describe.

While the deployed smart-contracts support the whitelisting of additional owners besides the signer account, the SDK itself does not provide a way to clone the contract using the factory with the owners parameter.

Describe the solution you'd like

export const coinbaseWalletSdk = new CoinbaseWalletSDK({
  appName: "An Awesome App",
  appChainIds: [84532],
  owners: [address1, address2] // would be nice to have this here
});

Describe alternatives you've considered

Currently, approving an additional owner on top of the first-time signer has to take place in a separate transaction, which is contrary to the general "easy to onboard", "set up in 10 seconds" narrative.

Additional context

No response

wilsoncusack commented 1 month ago

Thanks! Is the idea here that keys.conbase.com still creates the account, and you can pass owners? Or you want a full SDK for interacting with the smart contracts directly?

bangtoven commented 2 weeks ago

I apologize for mistakenly closing this feature request issue. it was an error on my part. reopened the issue and will review it promptly. thanks for your understanding.