Improve popup lifecycle management

coinbase / coinbase-wallet-sdk

An open protocol that lets users connect their mobile wallets to your DApp

https://coinbase.github.io/coinbase-wallet-sdk/

MIT License

1.4k stars 521 forks source link

Improve popup lifecycle management #1276

Closed bangtoven closed 2 months ago

bangtoven commented 2 months ago

Summary

introduce a dedicated method postRPCRequest which manages the pending requests and determines when to call disconnect to close the popup
postMessage: no conditional behavior
replace binding with const func blocks

How did you test your changes?

new unit tests
playground

bangtoven commented 2 months ago

turned out that closePopup call on the sdk side had no effect, as popup had has been responsible for closing itself whole time. sdk shouldn't interfere in. popup is taking care of it all. closing this pr, replacing it with https://github.com/coinbase/coinbase-wallet-sdk/pull/1279