coinbase / coinbase-wallet-sdk

An open protocol that lets users connect their mobile wallets to your DApp

https://coinbase.github.io/coinbase-wallet-sdk/

MIT License

1.4k stars 521 forks source link

#trivial SDK doesn't need to close the popup #1280

Closed bangtoven closed 3 weeks ago

bangtoven commented 2 months ago

Summary

addressing https://github.com/coinbase/coinbase-wallet-sdk/pull/1279#discussion_r1594823480 no code change. only comments / folder reorg.

How did you test your changes?

cb-heimdall commented 1 month ago

🟡 Heimdall Review Status

Item Status More Info

Minimum Required Reviews

🟡 0/1

Show calculation

Show calculations

1 if user is bot 0

1 if user is external 0

From .codeflow.yml 1

Additional review requirements

Show calculations

Max

From CODEOWNERS 0

Global minimum 0

Max 1

1 if commit is unverified 0

Sum 1

📝 Heimdall docs · 🕵️ Advanced details · ♻️ Refresh Heimdall · #️⃣ #ask-heimdall

jbjornivar commented 3 weeks ago

Im ready

man. 24. jun. 2024 kl. 20:38 skrev Jungho Bang @.***>:

Merged #1280 https://github.com/coinbase/coinbase-wallet-sdk/pull/1280 into master.

— Reply to this email directly, view it on GitHub https://github.com/coinbase/coinbase-wallet-sdk/pull/1280#event-13270334076, or unsubscribe https://github.com/notifications/unsubscribe-auth/A6QTYORWYSX47FMSVY3GR43ZJBRS7AVCNFSM6AAAAABHN5DLAWVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTGI3TAMZTGQYDONQ . You are receiving this because you are subscribed to this thread.Message ID: @.*** .com>