search

coinbase / coinbase-wallet-sdk

An open protocol that lets users connect their mobile wallets to your DApp
https://coinbase.github.io/coinbase-wallet-sdk/
MIT License
1.4k stars 521 forks source link

protected initSigner #1282

Closed fan-zhang-sv closed 2 months ago

fan-zhang-sv commented 2 months ago

Summary

How did you test your changes?

bangtoven commented 2 months ago

is this for wallet to inherit the provider? if so, let's revisit.

  1. i don't think this is necessary for wallet to inherit
  2. even if it's needed, i'd rather create a separate provider class on wallet side, instead of trying to generalize the behavior of sdk's provider. cc @fan-zhang-sv
fan-zhang-sv commented 2 months ago

sg will revisit this when developing for wallet