Fix popup blocked on Safari

coinbase / coinbase-wallet-sdk

An open protocol that lets users connect their mobile wallets to your DApp

MIT License

1.45k stars 556 forks source link

Closed arjun-dureja closed 4 months ago

arjun-dureja commented 4 months ago

Safari was blocking the popup from opening whenever a request was sent. This is because the request message is being constructed before the popup is opened in SCWSigner. Safari blocks it because it is not opened immediately after a button is clicked.
- This PR updates the request method so that it first opens the popup and then constructs the request. This is how it was done before this PR

Before	After

wilsoncusack commented 4 months ago

@bangtoven for sake of speed, maybe you should take over PR with the changes you want? Not sure what else @arjun-dureja has on plate today