search

coinbase / coinbase-wallet-sdk

An open protocol that lets users connect their mobile wallets to your DApp
https://coinbase.github.io/coinbase-wallet-sdk/
MIT License
1.4k stars 521 forks source link

Fix playground example send: don't send to wallets own address #1297

Closed nateReiners closed 1 month ago

nateReiners commented 1 month ago

dapps are blocked from calling directly to the smart wallet's address

Summary

How did you test your changes?

cb-heimdall commented 1 month ago

Review Error for bangtoven @ 2024-05-20 23:55:34 UTC User failed mfa authentication, see go/mfa-help

spencerstock commented 1 month ago

i'd just remove send shortcut

If we can find a suitable hardcoded address I think it's valuable... I've clicked the send shortcut at least 300x to test local changes.

nateReiners commented 1 month ago

what address is this?

Just one of my empty smart wallet test accounts

bangtoven commented 1 month ago

@spencerstock why not running a new dapp dedicated to do so and automate what you need. if i see other wallet or aggregator demo site has this kind of hardcoded address, especially as a send-to address, i would find it very fishy. cc @nateReiners

spencerstock commented 1 month ago

@spencerstock why not running a new dapp dedicated to do so and automate what you need. if i see other wallet or aggregator demo site has this kind of hardcoded address, especially as a send-to address, i would find it very fishy. cc @nateReiners

@bangtoven Would you be alright with 0x0000000000000000000000000000000000000000 the universal black hole address?