Closed arjun-dureja closed 1 month ago
There's an issue on iPads where the object returned from window.open stays defined even after the window/tab is closed. This causes the popup to not be opened when one was opened in the past due to this line of code: https://github.com/coinbase/coinbase-wallet-sdk/blob/53f37742c40ff5c20f6c652611b322c318332328/packages/wallet-sdk/src/core/communicator/Communicator.ts#L82-L83
window.open
To solve this, I added a check for popup.closed on the same line, so that the popup is opened again when it's closed
popup.closed
Summary
There's an issue on iPads where the object returned from
window.open
stays defined even after the window/tab is closed. This causes the popup to not be opened when one was opened in the past due to this line of code: https://github.com/coinbase/coinbase-wallet-sdk/blob/53f37742c40ff5c20f6c652611b322c318332328/packages/wallet-sdk/src/core/communicator/Communicator.ts#L82-L83To solve this, I added a check for
popup.closed
on the same line, so that the popup is opened again when it's closedHow did you test your changes?