issues
search
coinbase
/
coinbase-wallet-sdk
An open protocol that lets users connect their mobile wallets to your DApp
https://coinbase.github.io/coinbase-wallet-sdk/
MIT License
1.45k
stars
561
forks
source link
[WL refactor] clean up Relay
#1374
Closed
bangtoven
closed
1 month ago
bangtoven
commented
1 month ago
Summary
simplify WalletLinkRelay constructor
access control
consolidate metadata
remove redundant code
deprecate unnecessary "generic" method type
simplify chainid
How did you test your changes?
unit tests
cb-heimdall
commented
1 month ago
✅ Heimdall Review Status
Requirement
Status
More Info
Reviews
✅
1/1
Denominator calculation
Show calculation
1
if user is bot
0
1
if user is external
0
From
.codeflow.yml
1
Additional review requirements
Show calculation
Max
0
0
From
CODEOWNERS
0
Global minimum
0
Max
1
1
1
if commit is unverified
0
Sum
1
Summary
How did you test your changes?
unit tests