coinbase / coinbase-wallet-sdk

An open protocol that lets users connect their mobile wallets to your DApp

https://coinbase.github.io/coinbase-wallet-sdk/

MIT License

1.45k stars 561 forks source link

Fix chainChanged event emitting for walletlink connection #1411

Closed nateReiners closed 1 week ago

nateReiners commented 1 week ago

Summary

This fixes a bug where the first 'chainChanged' was not being emitted because no emitter callback was being passed to the WalletLinkSigner created by listenForWalletLinkSessionRequest

How did you test your changes?

Locally

Here's a video showing the bug in 4.1.0 and this fix in HEAD https://github.com/user-attachments/assets/e762a9d1-69f1-4124-a844-cf0dc346e9df

cb-heimdall commented 1 week ago

✅ Heimdall Review Status

Requirement Status More Info

Reviews

✅ 2/1

Denominator calculation

Show calculation

1 if user is bot 0

1 if user is external 0

From .codeflow.yml 1

Additional review requirements

Show calculation

Max

From CODEOWNERS 0

Global minimum 0

Max 1

1 if commit is unverified 0

Sum 1