search

coinbase / commerce-onchain-payment-protocol

Apache License 2.0
126 stars 40 forks source link

update TransferIntent id type to bytes32 #18

Open kylekaplan opened 3 months ago

kylekaplan commented 3 months ago

Hi,

I was wondering if the id field of the TransferIntent could be updated to a bytes32 instead of bytes16.

This would make it so the Keccak256 hash function could be used to generate predictable ids and be more compatible with other protocols generating ids with Keccak256.

For my use case, I'm using EAS (Ethereum Attestation Service) as a backend to create an on-chain eCommerce solution, and it would be nice if I could use an attestation UID (a Keccak256 hash of the attestation) as the id for the TransferIntent. This would make the relationship between an attestation and a TransferIntent simpler and more efficient.


Thanks for your consideration and for this awesome protocol.

cb-heimdall commented 3 months ago

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2
Nichebiche commented 3 months ago

Agreed

cb-heimdall commented 3 months ago

Review Error for TELLYWHALE @ 2024-08-11 00:05:58 UTC User must have write permissions to review

cb-heimdall commented 3 months ago

Review Error for TELLYWHALE @ 2024-08-11 00:30:59 UTC User must have write permissions to review

cb-heimdall commented 3 months ago

Review Error for Nichebiche @ 2024-08-27 21:09:33 UTC User must have write permissions to review

cb-heimdall commented 2 months ago

Review Error for MTerrases22 @ 2024-09-21 22:09:21 UTC User must have write permissions to review

Nichebiche commented 2 months ago

Does this mean I now have write access and permissions ? 

Sent from Yahoo Mail for iPhone

On Saturday, September 21, 2024, 6:09 PM, Heimdall @.***> wrote:

Review Error for MTerrases22 @ 2024-09-21 22:09:21 UTC User must have write permissions to review

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

cb-heimdall commented 2 months ago

Review Error for Nichebiche @ 2024-09-21 22:14:21 UTC User must have write permissions to review

cb-heimdall commented 2 months ago

Review Error for Irasone @ 2024-09-21 22:43:13 UTC User must have write permissions to review

cb-heimdall commented 2 months ago

Review Error for Irasone @ 2024-09-21 22:44:29 UTC User must have write permissions to review

MTerrases22 commented 2 months ago

Why haven't I received payment? I've been mistreated here. This is my account and no one should be preventing me from it. I'm so not letting this one go . I can't retrieve my funds. Someone took my identity and keeps locking me out of my account. I want my account left alone. It's my money not anyone else's.

MTerrases22 commented 1 month ago

What am I supposed to do with this

Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Sturgeontara06 @.> Sent: Thursday, October 10, 2024 5:17:24 PM To: coinbase/commerce-onchain-payment-protocol @.> Cc: Marlyn Elizabeth Terrases @.>; Comment @.> Subject: Re: [coinbase/commerce-onchain-payment-protocol] update TransferIntent id type to bytes32 (PR #18)

@Sturgeontara06 commented on this pull request.

Sure

— Reply to this email directly, view it on GitHubhttps://github.com/coinbase/commerce-onchain-payment-protocol/pull/18#pullrequestreview-2361656555, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BKBCEVRTDEKIT4I26JEKKLTZ24KJJAVCNFSM6AAAAABMBGYTBKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNRRGY2TMNJVGU. You are receiving this because you commented.Message ID: @.***>

cb-heimdall commented 1 month ago

Review Error for Irasone @ 2024-10-11 01:46:04 UTC User must have write permissions to review

MTerrases22 commented 1 month ago

Please check now.

Was this taken care of?

On Thu, Oct 10, 2024 at 6:46 PM Heimdall @.***> wrote:

Review Error for Irasone @ 2024-10-11 01:46:04 UTC User must have write permissions to review

— Reply to this email directly, view it on GitHub https://github.com/coinbase/commerce-onchain-payment-protocol/pull/18#issuecomment-2406373162, or unsubscribe https://github.com/notifications/unsubscribe-auth/BKBCEVV2W734MHHH7XEHXZDZ24UXFAVCNFSM6AAAAABMBGYTBKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBWGM3TGMJWGI . You are receiving this because you commented.Message ID: @.*** com>

-- Marlyn E.Terrases

MTerrases22 commented 1 month ago

Awesome, thank you so much!

On Thu, Oct 10, 2024 at 6:46 PM Irasone @.***> wrote:

@.**** approved this pull request.

— Reply to this email directly, view it on GitHub https://github.com/coinbase/commerce-onchain-payment-protocol/pull/18#pullrequestreview-2361759224, or unsubscribe https://github.com/notifications/unsubscribe-auth/BKBCEVU2SJTN3OIAJ43B5MLZ24UW5AVCNFSM6AAAAABMBGYTBKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNRRG42TSMRSGQ . You are receiving this because you commented.Message ID: <coinbase/commerce-onchain-payment-protocol/pull/18/review/2361759224@ github.com>

-- Marlyn E.Terrases

MTerrases22 commented 1 month ago

How can I access that check. With authorization of course. Been locked out and unable to claim my assets.someone please help me.

MTerrases22 commented 1 month ago

Hello, I haven't been getting my emails.

On Sat, Sep 21, 2024 at 3:44 PM Heimdall @.***> wrote:

Review Error for Irasone @ 2024-09-21 22:44:29 UTC User must have write permissions to review

— Reply to this email directly, view it on GitHub https://github.com/coinbase/commerce-onchain-payment-protocol/pull/18#issuecomment-2365345091, or unsubscribe https://github.com/notifications/unsubscribe-auth/BKBCEVT74XR3KDXOWRJQ76DZXXZGHAVCNFSM6AAAAABMBGYTBKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRVGM2DKMBZGE . You are receiving this because you commented.Message ID: @.*** com>

-- Marlyn E.Terrases

cb-heimdall commented 1 month ago

Review Error for Tinaochoa8462 @ 2024-10-24 07:38:24 UTC User must have write permissions to review

cb-heimdall commented 3 weeks ago

Review Error for joeltato @ 2024-11-07 11:33:52 UTC User must have write permissions to review

joeltato commented 3 weeks ago

how get my funds

On Thu, Nov 7, 2024 at 5:34 AM Heimdall @.***> wrote:

Review Error for joeltato @ 2024-11-07 11:33:52 UTC User must have write permissions to review

— Reply to this email directly, view it on GitHub https://github.com/coinbase/commerce-onchain-payment-protocol/pull/18#issuecomment-2462005594, or unsubscribe https://github.com/notifications/unsubscribe-auth/BMUM4PVE4A55VG7KR4S35DTZ7NF3NAVCNFSM6AAAAABMBGYTBKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRSGAYDKNJZGQ . You are receiving this because you commented.Message ID: @.*** com>