search

coinbase / kryptology

Apache License 2.0
847 stars 124 forks source link

Issue in SecretKeyShare.UnmarshalBinary #51

Closed dB2510 closed 2 years ago

dB2510 commented 2 years ago

I am suspecting there is a bug in https://github.com/coinbase/kryptology/blob/f7f15f217682f3e13b88846a419bce94bc3f7f73/pkg/signatures/bls/bls_sig/lib.go#L144 When calling UnmarshalBinary on bls_sig.SecretKeyShare struct it gives empty value attribute. Here's the way to reproduce it: https://github.com/coinbase/kryptology/pull/50 Here's the possible fix to this issue: https://github.com/coinbase/kryptology/pull/52

We at Obol when updated to latest v1.8.0 found this issue while updating our codebase.

dB2510 commented 2 years ago

@mikelodder7 @Arash-Afshar

mikelodder7 commented 2 years ago

Odd because our tests are passing. I’ll take a look on monday

dB2510 commented 2 years ago

Odd because our tests are passing. I’ll take a look on monday

Sure, thanks

Arash-Afshar commented 2 years ago

Interesting that the new test you submitted also does not seem to catch it https://github.com/coinbase/kryptology/pull/50.

The tests passes on my machine. I'll look more into it.