coinbase / mesh-cli

CLI for the Mesh API
Apache License 2.0
156 stars 94 forks source link

check:data Last question: Reconciliation is NOT TESTED??? #358

Open Li-LaoShi opened 2 years ago

Li-LaoShi commented 2 years ago

other question is passed ,but Reconciliation is NOT TESTED. what add "xxx":"xxx" for config.json. How can i to do ? please tell me ,thank you very much!!!

GeekArthur commented 2 years ago

Can you elaborate the following things:

Li-LaoShi commented 2 years ago

Which are the api ports that must be implemented, I want to pass data api and consturction api of rosetta-cli .but I don't want to implement them all。

Jingfu Wang @.***> 于2022年9月15日周四 23:40写道:

Can you elaborate the following things:

  • What use case you are trying to test?
  • How do you test with reproducible steps?
  • What the expected results vs actual results?

— Reply to this email directly, view it on GitHub https://github.com/coinbase/rosetta-cli/issues/358#issuecomment-1248278104, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYMCDKS2WGEW2PDZFXQ4TNTV6M7PDANCNFSM6AAAAAAQNHOOH4 . You are receiving this because you authored the thread.Message ID: @.***>

Li-LaoShi commented 2 years ago

hello my friend @GeekArthur Jingfu Wang .I want to pass data api and construction api of rosetta-cli. Now, data api have last question ==> Reconciliation is NOT TESTED. I don't know if there is something missing in my config.json => "data": { "active_reconciliation_concurrency":16, "inactive_reconciliation_concurrency":4, "inactive_reconciliation_frequency":250, "ignore_reconciliation_error":false, "bootstrap_balances":"bootstrap_balances.json", "historical_balance_disabled":true, "interesting_accounts":"interesting_accounts.json", "reconciliation_disabled":false, "reconciliation_drain_disabled":true, "balance_tracking_disabled":false, "coin_tracking_disabled": true, "exempt_accounts":"exampt_accounts.json", "end_conditions": { "duration": 20 } }

I just want the simplest use case to make sure that the coinbase exchange can be met. can you tell me how to do? thank you very much!

Li-LaoShi commented 2 years ago

Can you elaborate the following things:

  • What use case you are trying to test?
  • How do you test with reproducible steps?
  • What the expected results vs actual results?

*first, I want my blockchain to pass the test and meet the requirements of the coinbase exchange

*I have completed the development of my blockchain api based on rosetta-cli, but now check:data and the last one it does not detect, check:construction tells me that /construction/preprocess needs to be implemented, I have not implemented all of them, so I Wondering what needs to be done

*The test result is definitely not passed, so I am asking for your help, the reason has been mentioned in the first two

GeekArthur commented 2 years ago

You should follow Getting Started for what APIs you need to implement and How to Write a Configuration File for rosetta-cli Testing for how to test your implementation properly

Also which blockchain you are working on?

Li-LaoShi commented 2 years ago

I am AELF blockchain's Technical Engineer,Currently responsible for developing rosetta api, in order to connect with coinbase