search

coinbase / mesh-ethereum

Ethereum Mesh API Implementation
Apache License 2.0
102 stars 70 forks source link

Update README file #75

Closed racbc closed 2 years ago

racbc commented 2 years ago

Fixes #74.

Motivation

Readme file needed to be clearer.

Solution

Update formatting and processes.

Open questions

Anything else I should add?

racbc commented 2 years ago

Whoops. I read this last after committing one change from the UI. Let me know if there are issues.

On Wed, Nov 24, 2021 at 8:14 PM Madhur Shrimal @.***> wrote:

@.**** requested changes on this pull request.

I have suggested some changes. Please take a look. Don't commit suggestions from the UI as they won't be signed. Make changes in local and push. Thanks!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/coinbase/rosetta-ethereum/pull/75#pullrequestreview-815501040, or unsubscribe https://github.com/notifications/unsubscribe-auth/AV6KDN3SUBCZMVXNVVOFFQDUNWLXPANCNFSM5IUSTEMA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

shrimalmadhur commented 2 years ago

Whoops. I read this last after committing one change from the UI. Let me know if there are issues. … On Wed, Nov 24, 2021 at 8:14 PM Madhur Shrimal @.> wrote: @*.** requested changes on this pull request. I have suggested some changes. Please take a look. Don't commit suggestions from the UI as they won't be signed. Make changes in local and push. Thanks! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#75 (review)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AV6KDN3SUBCZMVXNVVOFFQDUNWLXPANCNFSM5IUSTEMA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

changes looks good. I think there's a conflict you would need to resolve before I can approve and merge.