search

coinbase / mesh-ethereum

Ethereum Mesh API Implementation
Apache License 2.0
102 stars 70 forks source link

/block/transaction Endpoint not implemented #85

Closed fboucquez closed 2 years ago

fboucquez commented 2 years ago

Hi team,

The /block/transaction endpoint is not implemented for some reason.

https://github.com/coinbase/rosetta-ethereum/blob/master/services/block_service.go#L71

It doesn't seem particularly hard to implement considering that the /block endpoint returns the block with all the transactions.

Any reason why this one wasn't implemented?

shrimalmadhur commented 2 years ago

Hi @fboucquez , thanks for the issue. I don't think so there's any reason. I will try to implement this next week. Although if you are interested, feel free to implement it. Contributions are always welcome 😄

thepabloaguilar commented 2 years ago

@shrimalmadhur do you mind if I try to implement that endpoint?

shrimalmadhur commented 2 years ago

Hello @thepabloaguilar , thanks for offering. I actually went ahead and implemented it, I am just working on some unit tests and will be raising the PR for this by end of this week. If you want, you can try to tackle these issue - https://github.com/coinbase/rosetta-ethereum/issues/71 or https://github.com/coinbase/rosetta-ethereum/issues/73

thepabloaguilar commented 2 years ago

Yoo, no worries! I'll take a look rn on those you sent

Btw, could you ping me on the PR about this issue? I'm trying to understand more about this project