[Refactor] re-using rpcTransaction type - Githubissues

coinbase / mesh-ethereum

Ethereum Mesh API Implementation

Apache License 2.0

102 stars 70 forks source link

[Refactor] re-using rpcTransaction type #96

Closed viveksb007 closed 2 years ago

viveksb007 commented 2 years ago

Fixes # .

Motivation

txPoolTxInfo is redundant type.
TxPoolContentResponse is exposed outside ethereum package.

Solution

We can re-use rpcTransaction defined above. rpcTransaction is using Transaction model from go-ethereum instead of re-write.
Made TxPoolContentResponse package private.

Open questions

I was working on issue #91, raised refactoring PR as to not merge this change in mempool/transaction impl PR.