coinbase / mesh-geth-sdk

go-ethereum based sdk for Mesh API
https://docs.cdp.coinbase.com/mesh/docs/getting-started/
Apache License 2.0
28 stars 29 forks source link

Use special strings for methodSig to handle contract call by pre-compiled ABI data #123

Closed songge-cb closed 4 months ago

songge-cb commented 4 months ago

Motivation

This PR is to add some logic to the preprocess API to handle fallback pattern contract call. This type of contract call does not have a method signature.

Solution

We will use either empty string or a unique string "NO-METHOD-SIG" to indicate it. The pre-compiled ABI data will be passed in as methodArgs, either in the string format or the first element of an array.

Testing

Open questions

cb-heimdall commented 4 months ago

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1