coinbase / mesh-specifications

Specification files for the Mesh Blockchain Standard
Apache License 2.0
324 stars 92 forks source link

rosetta-bitcoin and rosetta-ethereum return invalid response on /network/options request #111

Closed dvc94ch closed 2 years ago

dvc94ch commented 2 years ago

The rosetta-bitcoin and rosetta-ethereum set the call_methods and balance_exemptions to null. The spec mandates a type of array. It seems like the correct thing to do would be to set the fields to nullable in the spec or return empty arrays in the implementations. Alternatively it would be even better to make the fields optional, but that's a backwards compatibility issue.

GeekArthur commented 2 years ago

Thanks for the callout. The rosetta-bitcoin and rosetta-ethereum should update call_methods and balance_exemptions to zero value (empty array) to comply rosetta spec. I created two issues for them accordingly:

I will close this issue and the issue tracking and fix will be moved to the specific rosetta implementations.