coinbase / mesh-specifications

Specification files for the Mesh Blockchain Standard
Apache License 2.0
324 stars 92 forks source link

Consider add block height into /account/balance request/response #16

Closed raullenchai closed 4 years ago

raullenchai commented 4 years ago

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] Without block height, the returned balance does not make sense.

Describe the solution you'd like A clear and concise description of what you want to happen. add block height into /account/balance request/response, e.g., https://www.rosetta-api.org/docs/AccountApi.html

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

patrick-ogrady commented 4 years ago

👋 @raullenchai The /account/balance request already allows the client to optionally specify a block height to look up a balance (if it is not provided, it is assumed to be a balance lookup at the last block synced by the node).

The /account/balance response already returns the block height (and associated block hash) at which the balance was calculated.

Since this functionality already exists in the specification, I'm going to close this issue.

raullenchai commented 4 years ago

Thanks for the clarification

patrick-ogrady commented 4 years ago

If you have any questions while working on an implementation, feel free to reach out here!