coinbase / mesh-specifications

Specification files for the Mesh Blockchain Standard
Apache License 2.0
324 stars 92 forks source link

Add `historical_balance_lookup` to `NetworkOptionsResponse` #19

Closed patrick-ogrady closed 4 years ago

patrick-ogrady commented 4 years ago

Is your feature request related to a problem? Please describe. When running rosetta-cli check, the only argument that developers ever provide (to override the default) is --lookup-balance-by-block=false. This argument has caused a lot of confusion and the specification should be modified so that this can be inferred automatically from an implementation.

Describe the solution you'd like Add something like historical_balance_lookup to NetworkOptionsResponse so that we can remove this setting entirely from rosetta-cli. https://github.com/coinbase/rosetta-specifications/blob/439b881859b0982bb6baf34a9666db1018d419f9/api.yaml#L615-L627

Describe alternatives you've considered We already provide a lot of documentation around this flag but it is often overlooked during implementation as there are so many other factors on developers' minds.