search

coinbase / mesh-specifications

Specification files for the Mesh Blockchain Standard
Apache License 2.0
324 stars 92 forks source link

feat/add-ecschnorr-declaration #36

Closed teye closed 4 years ago

teye commented 4 years ago

This pr adds the support for Ec-Schnorr signature type.

I am a developer from Zilliqa; working on a rosetta sdk implementation for our side. As our blockchain employs a secp256k1 Curve with a schnorr Signature Type, we hope to include this signature and subsequently the signer and verify support into rosetta-sdk-go.

Zilliqa Schnorr Signature: https://dev.zilliqa.com/docs/basics/basics-zil-schnorr-signatures/ Contact: teye@zilliqa.com

patrick-ogrady commented 4 years ago

Thanks for posting this @teye! Before I can review, you'll need to sign your commits.

patrick-ogrady commented 4 years ago

We took a look at your whitepaper but didn't find any discussion about encoding (other than that it is 64 bytes). How does the Zilliqa schnorr signature encoding format compare to the one proposed in BIP 340?

teye commented 4 years ago

Sorry for the trouble, I will re-do this pr with a proper signed commits and also get back to the team about the implementations.