search

coinbase / mesh-specifications

Specification files for the Mesh Blockchain Standard
Apache License 2.0
327 stars 93 forks source link

Add secp256r1 to CurveType #39

Closed joeqian10 closed 4 years ago

joeqian10 commented 4 years ago

Motivation

NEO uses P256.

patrick-ogrady commented 4 years ago

👋 @joeqian10 You'll need to run make gen to pass check-gen: https://github.com/coinbase/rosetta-specifications#specification-development

Otherwise, everything else looks good!

joeqian10 commented 4 years ago

@patrick-ogrady Hi Patrick, can you explain more about what I need to do to pass check-gen. I spent half hour on this and still got no ideas, since this is new stuff for me. Thanks!

patrick-ogrady commented 4 years ago

What error are you getting @joeqian10? Have you run make deps? What version of node are you running?

patrick-ogrady commented 4 years ago

@joeqian10 looks like the latest commit (that fixed the issue) wasn't signed...you'll need to do so before I can merge this!

joeqian10 commented 4 years ago

@patrick-ogrady Thank you so much for all the guidance and help!