search

coinbase / mesh-specifications

Specification files for the Mesh Blockchain Standard
Apache License 2.0
324 stars 92 forks source link

[Construction] Options Parity #54

Closed patrick-ogrady closed 4 years ago

patrick-ogrady commented 4 years ago

@matheusd brought up the strange lack of "required" parity between ConstructionPreprocessResponse.Options and ConstructionMetadataRequest.Options in https://github.com/coinbase/rosetta-sdk-go/pull/166. This was originally intended so the caller to opt to avoid calling /construction/metadata if there were no ConstructionPreprocessResponse.Options.

As a result of the conversation on that PR, we've decided it is best to not make Options required in ConstructionMetadataRequest in the case that an implementer does not need to pass any info related to the /construction/preprocess execution. As a side note, this means we can remove the conditional nature of the Construction API flow.

Changes

heimdall-asguard commented 4 years ago

If Heimdall is stuck, please click the following link: https://heimdall-public.cbhq.net/v1/pull_request/stuck?pr_number=54&repository=coinbase/rosetta-specifications