Closed kyhyco closed 3 months ago
UI:
Update the address color to foreground-muted
/Gray 600
Increase top and bottom padding by 8px each.
@mindapivessa
@kyhyco can we remove top padding and only add the bottom. I think you just added the top
@kyhyco I like this direction a lot, and I like how you made it super easy to include IdentityProvider.
<Wallet>
<ConnectWallet>
<Avatar className="h-6 w-6" />
<Name />
</ConnectWallet>
<WalletDropdown>
<IdentityLayout>
<Avatar />
<Name>
<Badge />
</Name>
<Address className={color.foregroundMuted} />
</IdentityLayout>
<WalletDisconnect />
<GoToWalletDashboard />
</WalletDropdown>
</Wallet>
So there are only 3 points I would like to reflect as follow up PR.
<IdentityLayout />
, I feel like it removes the magic. I feel like that's a special case of a WalletDropdownItem, so should this instead being named <WalletDropodownIdentity />
?<WalletDisconnect />
let's probably name it <WalletDropdownDisconnect />
so it's clear is part of the dropdown<WalletDropdownLink />
<GoToWalletDashboard />
to make it super easy for this particular case, than let's try to have it with a name normalized for this case so <WalletDropdownDashboardLink />
What changed? Why?
Component API
Notes to reviewers
How has it been tested?