coinbase / onchainkit

React components and TypeScript utilities to help you build top-tier onchain apps.
https://onchainkit.xyz
MIT License
534 stars 123 forks source link

docs: Add isSliced option to Address and remove slice logic from Name #733

Closed cpcramer closed 2 months ago

cpcramer commented 3 months ago

What changed? Why? Tracking issue: https://github.com/coinbase/onchainkit/issues/732

Part Description Status
1 [Part 1] feat: Add isSliced option to Address and remove slice logic from Name
2 [Part 2] docs: Add isSliced option to Address and remove slice logic from Name In Progress

Add the isSliced option to the Address component. This allows the component to render the full users address when set to false.

Update the Name component to remove slice logic and return null if the ENS name is not found.

Notes to reviewers

How has it been tested? Address page:

Screenshot 2024-07-09 at 3 42 09 PM

Name page:

Screenshot 2024-07-09 at 3 40 45 PM

Added sub sections to Address and Name

Screenshot 2024-07-09 at 3 42 28 PM

Improved Name example visibility: Before

Screenshot 2024-06-28 at 2 02 16 PM

After

Screenshot 2024-07-09 at 3 41 33 PM

Improved Address example visibility: Before

Screenshot 2024-06-28 at 2 04 39 PM

After

Screenshot 2024-07-09 at 3 41 47 PM